Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on circle fill,circle stroke option #50

Closed
ashwani-rathee opened this issue Mar 13, 2021 · 2 comments · Fixed by #51
Closed

Discussion on circle fill,circle stroke option #50

ashwani-rathee opened this issue Mar 13, 2021 · 2 comments · Fixed by #51

Comments

@ashwani-rathee
Copy link
Member

I needed those for example : Detection and measurement,indentification of circular objects in a image
Even though Luxor.jl provides functions for that,would we need it here?Just a simple circular,elliptical drawable is unintuitive when we explain more advanced ideas there
Idea: https://github.com/ashwani-rathee/Demos/blob/main/%F0%9F%8E%88%202.pdf
relevant issues:
JuliaImages/ImageEdgeDetection.jl#21

What I kind of need

@johnnychen94 What do you think?

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 13, 2021

I guess we need two extra keywords thickness and fill::Bool to get this done. As you can see, writing demos do help us find out what the missing functionalities are and we definitely need some love to improve this package.

Never get a chance to use Luxor, though. The demos there looks quite nice but I don't know if it gives an out-of-box experience to draw on an image; it might not support the AbstractArray{<:Colorant} image type.

@ashwani-rathee
Copy link
Member Author

Okay,I'll start working on that.Yeah,writing demos kindof requires some taste in design,presentation,experimenting with various values/types of same thing(learned that from front-end person in our team,he took his time but whatever came out was usually better than what rest 3 of us made by quite a margin)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants