Intervalize contents of Aff #19
Open
+8
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need updating. |
|
The strange number in the above calculation is coming from julia> nextfloat(1e23) - 1e23
1.6777216e7
julia> x = interval(1e23) + interval(2020)
Interval(1.0e23, 1.0000000000000001e23)
julia> x.hi == nextfloat(x.lo)
true
|
|
In other words, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #14 in the most naive way: make everything stored inside the
Afftype (the internal component that does the affine calculation) into an interval when theAffobject is first created.The result of the example in #14 is as follows after this PR:
Due to the precision of Float64 I don't think we can expect a better answer than this.
However, with
BigFloatwe getwhich is correct!
(Note that there are some missing promotions to do
Affine(-1..1) + Affine(big(1)).)This PR surely does not give the fastest code, but at least it seems to be correct...
cc @mforets @RockerM4NHUN