Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IntervalSets.jl for set operations #366

Closed
dpsanders opened this issue Mar 8, 2020 · 3 comments
Closed

Use IntervalSets.jl for set operations #366

dpsanders opened this issue Mar 8, 2020 · 3 comments

Comments

@dpsanders
Copy link
Member

cf. discussion in JuliaMath/IntervalSets.jl#55

This is related to redefining .. to not do clever tricks and just take floating-point endpoints at face value.

@lbenet
Copy link
Member

lbenet commented Mar 8, 2020

For reference, see the discussion in #345.

Regarding using IntervalSets.jl for set operations, would that satisfy the standard?

@Kolaru
Copy link
Collaborator

Kolaru commented Mar 9, 2020

For most of it, it should, but some operation would need to be redefined. For example, for us, union of disjoint interval should return the hull instead of erroring.

While I like the idea of building intervals on a more fundamental package, I feel like in the current state we would loose too much flexibility for a rather small gain. More precisely, given the amount of manipulation we perform of the interval constructor and the restriction we impose on the bounds, I think that type piracy is not an option. And without type piracy, we can not share .. and would need to wrap IntervalSets intervals in ours to use the method defined for them.

@Kolaru
Copy link
Collaborator

Kolaru commented Sep 18, 2023

Discussed in today's call, in favor of status quo.

@Kolaru Kolaru closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants