Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DecoratedInterval the default #584

Closed
Kolaru opened this issue Sep 18, 2023 · 1 comment · Fixed by #590
Closed

Make DecoratedInterval the default #584

Kolaru opened this issue Sep 18, 2023 · 1 comment · Fixed by #590
Labels
1.0 Planned for the major 1.0 release

Comments

@Kolaru
Copy link
Collaborator

Kolaru commented Sep 18, 2023

It has been discussed during the JuliaInterval call a couple of time, but without a clear consensus yet.

I think it would be good to have DecoratedInterval as the default. A new user would be warn when something weird happen, and that's probably what we want for them.

As they become more advanced, they could discover the faster, less safe Interval without too much trouble.

Of course that would mean, renaming DecoratedInterval to Interval, and Interval to BareInterval.

@Kolaru Kolaru added 1.0 Planned for the major 1.0 release need discussion labels Sep 18, 2023
@OlivierHnt
Copy link
Member

One advantage of doing this is that we can reintroduce conversion (implicit or explicit) with numbers for DecoratedInterval by adding a specific decoration.
While BareInterval would be more conservative to avoid confusion. E.g. bareinterval(1) + 1 could either error, or return a DecoratedInterval with the correct decoration 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Planned for the major 1.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants