-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example 5.5 from Smiley and Chun (2001) solved inconsistently #86
Comments
Some progress on triangulating the issue: On my machine the example works with v0.7.0 of StaticArrays.jl and breaks with v0.7.2. |
The example is already broken with v0.7.1 of StaticArrays.jl |
git bisection indicates that the problem is related to this commit in StaticArrays.jl |
Great detective work, thanks. Would you like to report it at StaticArrays.jl? |
Sure, it cannot hurt to have them take a look at it. The code in question is called here, correct? |
Yes, that's the right place. |
Given that the next version of StaticArrays will most likely contain a fix for this issue, I think v0.7.1 through v0.7.2 of StaticArrays.jl should be blacklisted in IntervalRootFinding.jl's |
The discussion in the StaticArrays issue raised questions about the definition of
This definition seems both geneerous and too specific at the same time. My understanding is that the question "Is this number infinite?" cannot be answered at all for an interval that contains both an infinity and finite numbers. It could be both finite or infinite, and we don't know yet. Should I open an issue to discuss this further? |
Yes, I agree. Please do open an issue, yes. |
I think the solution for us is to use the work in #67. |
* Add methods for IntervalBox previously in IntervalRootFinding * Remove a reference to IntervalRootFinding, and fix complex interval test * Implement suggestions of the review * Incorporate a missing suggestion of the review
Yes, it makes sense to have a safe implementation of left divide within the package since that operation is so crucial to the Newton method. |
So should the methods in #67 be used instead of |
Yes, that's probably a good solution. Let's try it. |
Maybe make it do Gaussian elimination for now. |
Should it use the preconditioned version or the normal one? |
There should be an option to either use it or not, and test both to see which is better! |
I think this will be solved by using interval Gauss-Seidel instead of Gaussian elimination to solve the linear system. @Kolaru is it possible to specify this option? |
@dpsanders Currently it's not possible, the contractors using the I've added it to the list in #116 of what should be possible to pass to |
Silent failure should be solved by JuliaIntervals/IntervalArithmetic.jl#571 |
With the earlier change to the contractors (using a custom |
The example in
test/smiley_examples.jl
has 41 roots, however, only 20 are found on some setups. On other setups all 41 are identified correctly. This inconsistency was first discovered and discussed in #70.The text was updated successfully, but these errors were encountered: