RFC: revert "revert remove HashDict" #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.98% (diff: 100%)@@ master #252 diff @@
==========================================
Files 31 30 -1
Lines 2486 2192 -294
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2310 2104 -206
+ Misses 176 88 -88
Partials 0 0
|
|
This fixes the Gadfly problem I hope? |
kmsquire
force-pushed
the
kms/revert_remove_hashdict
branch
3 times, most recently
from
11a10da
to
58978cc
Compare
kmsquire
force-pushed
the
kms/revert_remove_hashdict
branch
from
58978cc
to
b43d0b5
Compare
This reverts commit 4a9edb3.
* Previously, `getindex` always called "get!(h::Associative, key, default)"
to return a default value.
* When DefaultDict was based on HashDict (now deleted) and the
default value was calculated using a function, a version of this
function with signature
get!(h::HashDict, key, default::Base.Callable)
was called.
* Base.Dict has no such function (nor does DataStructures.OrderedDict),
so the (incorrect) value returned was the function object which
generated the default value, not the default value itself.
* Additionally, there were no tests for DefaultDicts with defaults
generated by a function.
* Fixed so that getindex calls the `do` function form of `get!` when
appropriate
* Added tests for DefaultDicts with defaults generated by functions
* Used by Gadfly
kmsquire
force-pushed
the
kms/revert_remove_hashdict
branch
from
b43d0b5
to
e1ae53e
Compare
kmsquire
changed the title
kmsquire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
HashDictagain, and fixes some issues uncovered by basingDefaultDicts onBase.Dictrather thanHashDict.Previously,
getindexalways calledget!(h::Associative, key, default)to return a default value.When DefaultDict was based on HashDict (now deleted) and the default value was calculated using a function, a version of this function with signature
was called.
Base.Dicthas no such function (nor doesDataStructures.OrderedDict), so the (incorrect) value returned was the function object which generated the default value, not the default value itself.Additionally, there were no tests for
DefaultDictswith defaults generated by a function.getindexcalls thedofunction form ofget!onDefaultDicts/DefaultOrderedDicts when appropriateDefaultDicts with defaults generated by functionsEdit: Also, add back functionality for pushing tuples to
DefaultDicts.