RFC: Fix delegation for *Dict functions returning the underlying *Dict #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this while working on #252. Should be uncontroversial, but I'm open to suggestions for alternative fixes, if anyone has any suggestions. |
Current coverage is 92.92% (diff: 100%)@@ master #253 diff @@
==========================================
Files 31 31
Lines 2485 2486 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2308 2310 +2
+ Misses 177 176 -1
Partials 0 0
|
* When called on an Associative container, delete!, empty!, sizehint! and setindex! all return the container * The `@delegate` macro is not aware of this, and instead returned the wrapped object. * Fixed by creating a second macro, `@delegate_return_parent`, which works like `@delegate`, but returns the parent container.
kmsquire
force-pushed
the
kms/fix_delegation
branch
from
c47ee58
to
1373a7b
Compare
* delete! * empty! * setindex! * sizehint!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associativecontainer,sizehint!,empty!, andsetindex!all return the container@delegatemacro is not aware of this, and instead returnedthe wrapped object when used to define, e.g.,
DefaultDicts@delegate_return_parent,which works like
@delegate, but returns the parent container.Edit:
delete!also returns the container.