Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate => syntax for --> #54

Merged
merged 1 commit into from Jul 28, 2015
Merged

deprecate => syntax for --> #54

merged 1 commit into from Jul 28, 2015

Conversation

jakebolewski
Copy link
Contributor

This gets around precedence issues of => due to JuliaLang/julia#12285

closes #51

factex.head != :(=>) && error("Incorrect usage of @fact: $factex")
if factex.head == :(=>)
Base.warn_once("the `=>` syntax is deprecated, use `-->` instead")
elseif factex.head == :(-->)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about != here? empty elseif looks a little funny

This gets around precedence issues of `=>` due to JuliaLang/julia#12285

closes #51
jakebolewski added a commit that referenced this pull request Jul 28, 2015
deprecate => syntax for -->
@jakebolewski jakebolewski merged commit 63bb200 into master Jul 28, 2015
@jakebolewski jakebolewski deleted the jcb/arrow branch July 28, 2015 18:17
@tkelman
Copy link
Contributor

tkelman commented Sep 11, 2015

We might want to consider going back on this, depending what happens with => and/or --> precedence on 0.5. Maybe the improvements to Base.Test will make FactCheck less necessary there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change result arrow from => to -->?
2 participants