Skip to content
This repository has been archived by the owner on Oct 21, 2021. It is now read-only.

RFC: to_dot accepts an AttributeDict for graph attributes #173

Merged
merged 1 commit into from Apr 13, 2015

Conversation

ggggggggg
Copy link
Contributor

To enable things like like overlap=false when using GraphViz.jl.

@mlubin
Copy link
Contributor

mlubin commented Apr 12, 2015

I'm a bit confused about all the to_dot and now to_dot_graph methods.
What's the difference between to_dot(::AttributeDict) and to_dot_graph(::AttributeDict)? Is the former used at all?

@ggggggggg
Copy link
Contributor Author

Graph wide attributes have different formatting (eg no brackets) than node
attributes, to_dot_graph implements this formatting.

On Sunday, April 12, 2015, Miles Lubin notifications@github.com wrote:

I'm a bit confused about all the to_dot and now to_dot_graph methods.
What's the difference between to_dot(::AttributeDict) and
to_dot_graph(::AttributeDict)? Is the former used at all?


Reply to this email directly or view it on GitHub
#173 (comment).

@mlubin
Copy link
Contributor

mlubin commented Apr 12, 2015

Thanks for the clarification. Could you just add a comment in the source to this effect?

@ggggggggg
Copy link
Contributor Author

Yeah. I can do it on Monday.

On Sunday, April 12, 2015, Miles Lubin notifications@github.com wrote:

Thanks for the clarification. Could you just add a comment in the source
to this effect?


Reply to this email directly or view it on GitHub
#173 (comment).

@ggggggggg
Copy link
Contributor Author

Updated with comments.

@mlubin
Copy link
Contributor

mlubin commented Apr 13, 2015

Thanks @ggggggggg. Could you squash the commits into one? (git rebase -i HEAD~3).
Will merge after that.

@ggggggggg
Copy link
Contributor Author

Ok.

mlubin added a commit that referenced this pull request Apr 13, 2015
RFC: to_dot accepts an AttributeDict for graph attributes
@mlubin mlubin merged commit 9197916 into JuliaAttic:master Apr 13, 2015
KristofferC pushed a commit to KristofferC/Graphs.jl that referenced this pull request Oct 9, 2021
KristofferC pushed a commit to KristofferC/Graphs.jl that referenced this pull request Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants