Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recent homebrew reorganization breakage #149

Merged
merged 3 commits into from Sep 20, 2016
Merged

Fix recent homebrew reorganization breakage #149

merged 3 commits into from Sep 20, 2016

Conversation

staticfloat
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 20, 2016 •
edited

Coverage Status

Coverage increased (+0.5%) to 71.892% when pulling 95f46d7 on sf/linked_fix into 144f527 on master.

tkelman
tkelman reviewed Sep 20, 2016
View reviewed changes
.travis.yml
@@ -1,8 +1,10 @@
language: julia
os:
- osx
osx_image: xcode7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no indentation on this unless it's inside a matrix include I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're too fast for me tony. Just too fast.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seriously, coincidence. was browsing on travis to see if re-caching things was going through

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staticfloat do you also get that panicky feeling when you accidentally push a commit with a typo to a random branch and then trying to do a git --amend, git push -f as fast as possible before Tony catches it :P.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moderately amazed when no one catches my screwups.

tkelman
tkelman reviewed Sep 20, 2016
View reviewed changes
.travis.yml
- osx
matrix:
- os: osx
osx_image: xcode7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 might have been a bad choice if this is one they're going to retire https://blog.travis-ci.com/2016-09-15-new-default-osx-image-coming/

@tkelman
Copy link
Contributor

tkelman commented Sep 20, 2016

I think osx_image: xcode7.3 can just be a top-level key

@coveralls
Copy link

coveralls commented Sep 20, 2016 •
edited

Coverage Status

Coverage remained the same at 71.351% when pulling b571d41 on sf/linked_fix into 144f527 on master.

@staticfloat staticfloat merged commit 3c80c5d into master Sep 20, 2016
@tkelman tkelman deleted the sf/linked_fix branch September 20, 2016 06:55
@coveralls
Copy link

coveralls commented Sep 20, 2016 •
edited

Coverage Status

Coverage remained the same at 71.351% when pulling b571d41 on sf/linked_fix into 144f527 on master.

@tkelman tkelman mentioned this pull request Sep 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@tkelman tkelman tkelman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@staticfloat @coveralls @tkelman @KristofferC