Merge pull request #69 from JuliaLang/ksh/errortests

Added error-throwing tests and fixed bugs

src/rlinalg.jl

@@ -25,7 +25,7 @@ function randnn(el, m::Int, normalize::Bool=true)
     elseif el <: Complex
         Ω = randn(m) + im*randn(m)
     else
-        throw(ValueError("Unsupported element type: $el"))
+        throw(ArgumentError("Unsupported element type: $el"))
     end
     normalize ? Ω/norm(Ω) : Ω
 end
@@ -35,7 +35,7 @@ function randnn(el, m::Int, n::Int, normalize::Bool=true)
     elseif el <: Complex
         Ω = randn(m, n) + im*randn(m, n)
     else
-        throw(ValueError("Unsupported element type: $el"))
+        throw(ArgumentError("Unsupported element type: $el"))
     end
     normalize || return Ω
     for i=1:n

src/svdl.jl

@@ -30,7 +30,7 @@ end
 function Base.getindex{T}(B::BrokenArrowBidiagonal{T}, i::Int, j::Int)
     n = size(B, 1)
     k = length(B.av)
-    if !(1 ≤ i ≤ n || 1 ≤ j ≤ n)
+    if !(1 ≤ i ≤ n && 1 ≤ j ≤ n)
         throw(BoundsError())
     end
 

test/rlinalg.jl

@@ -23,4 +23,8 @@ facts("Randomized linear algebra") do
 
     l, u = rcond(A, k, p)
     @fact l <= cond(A) <= u --> true
+
+    @fact_throws ArgumentError IterativeSolvers.randnn(Char, m)
+    @fact_throws ArgumentError IterativeSolvers.randnn(Char, m, n)
+
 end

test/svdl.jl

@@ -14,6 +14,7 @@ for method in (:ritz, :harmonic) context("Thick restart with method=$method") do
         q = convert(Vector{elty}, ones(n)/√n)
         σ, L = svdl(A, ns, v0=q, tol=tol, reltol=tol, maxiter=n, method=method, vecs=:none)
         @fact norm(σ - [n:-1.0:n-4;]) --> less_than(5^2*1e-5)
+        @fact_throws ArgumentError svdl(A, ns, v0=q, tol=tol, reltol=tol, maxiter=n, method=:fakemethod, vecs=:none)
 
         #Check the singular vectors also
         Σ, L = svdl(A, ns, v0=q, tol=tol, reltol=tol, maxiter=n, method=method, vecs=:both)
@@ -66,6 +67,8 @@ facts("BrokenArrowBidiagonal") do
     @fact B[3,3] --> 3
     @fact B[2,3] --> 2
     @fact B[3,2] --> 0
-    @fact B[1,3] --> 1
+    @fact B[1,3] --> 1 
+    @fact size(B) --> (3,3)
+    @fact_throws ArgumentError size(B,3)
+    @fact_throws BoundsError B[1,5]
 end
-