Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Migration of iterators to Base, and sync with 0.4 syntax #39

Merged
merged 3 commits into from May 6, 2015

Conversation

garborg
Copy link
Contributor

@garborg garborg commented Feb 14, 2015

Migration as of: JuliaLang/julia@7a8f434

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.48% when pulling 822a5da on garborg:migration into 107ff7a on JuliaLang:master.

@garborg
Copy link
Contributor Author

garborg commented Feb 14, 2015

(Passed locally on master and release-0.3, with deprecation warnings in only the right places on both (groupby and sometimes count).)

@garborg
Copy link
Contributor Author

garborg commented Feb 17, 2015

Bump.

The one other bit of work I could see doing is deprecating count in favor of countfrom on 0.3 as well, but that could also come later.

@garborg
Copy link
Contributor Author

garborg commented Feb 17, 2015

Unless it would be better to move all the now-Base iterators completely out of here, to Compat. And have this just use Compat? That seems better to me.

@jiahao
Copy link
Contributor

jiahao commented Mar 9, 2015

Let's have the test failure on 0.4 fixed and we can just merge it in without dawdling about where the code should go.

https://travis-ci.org/JuliaLang/Iterators.jl/jobs/50714323#L235

@coveralls
Copy link

Coverage Status

Coverage increased (+6.71%) to 80.19% when pulling c93de58 on garborg:migration into 107ff7a on JuliaLang:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.74%) to 87.22% when pulling c93de58 on garborg:migration into 107ff7a on JuliaLang:master.

@dcjones dcjones merged commit c93de58 into JuliaCollections:master May 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants