Fix emitting comments followed by \r\n
#455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/rn
branch
2 times, most recently
from
59f06bd
to
7bc40f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 96.43% 96.53% +0.09%
==========================================
Files 14 14
Lines 4208 4212 +4
==========================================
+ Hits 4058 4066 +8
+ Misses 150 146 -4 ☔ View full report in Codecov by Sentry. |
|
In Julia 1.0 and 1.8 we have |
|
Whether or not we merge this we should add a test for parsing |
Before this patch the `\r` character would be part of the comment and not the following NewlineWs (which would simply be a `\n`-style NewlineWs instead of a `\r\n` as one would expect).
|
Fixed. |
|
Whats the procedure to release a new version here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch the
\rcharacter would be part of the comment and not the following NewlineWs (which would simply be a\n-style NewlineWs instead of a\r\nas one would expect).