Use tk8.5 rather than tk8.6

[bdeonovic]

I think the Travis CI linux build is ubuntu 12.04 and has issues with TCL/TK 8.6. I think requiring TCL/TK 8.5 might make Travis CI tests pass.

[timholy]

It certainly got farther, but failed due to a lack of a DISPLAY. @IainNZ, I think you solved this for PkgEvaluator, how did you do it? Would it be possible to port your solution here?

Also, I'm not sure that outright replacement of 8.6 with 8.5 is the best answer; on systems that have 8.6 available, it's presumably better to use the later version. @staticfloat, you know better than me how this works; can he just add both to the list of aliases? What about the provides, etc commands?

[IainNZ]

I believe its as simple as xvfb-run julia -e 'Pkg.test("Tk")', at least thats enough for PkgEval

[timholy]

Conversely, @bdeonovic, you could steal from #85.

[bdeonovic]

Here's giving it a try. I wish I understood how the build.jl script worked and how BinDeps works.

[timholy]

Yay! Works! Really nice.

I may have to dig into the BinDeps source fairly soon (but not for a couple weeks, I have deadlines), so perhaps I'll be able to answer how to support both 8.5 and 8.6. But I'm also pinging @Keno who may be able to provide a quick answer.

[bdeonovic]

Great, so will this be pulled in?

[timholy]

Something like it definitely should be. But the problem is you've broken things for people using distributions that package 8.6, since that should presumably be used in preference to 8.5. What I'm hoping for is a way to use 8.6 if available, and 8.5 if not.

[bdeonovic]

I see, so perhaps some solution involving the use of library_group that has been mentioned in other issues.

[bdeonovic]

@timholy I updated the build.jl here a bit so that tcl/tk8.6 is still a valid library dependency. The only difference between this build file and the current one is if apt-get is used to download the tcl/tk depedency it will pull 8.5. I think this is appropriate since apt-get doesn't provide 8.6.

Otherwise, this build script will still get the 8.6 source files and install those.

[timholy]

Very good! Let's wait to see what trouble falls out, but green on Travis is good enough for me for now.

Thanks!

[tkelman]

both 8.5 and 8.6 are available in recent Ubuntu, but 8.6 isn't available on precise which is what Travis is still using.

[timholy]

Yes, I know. My suspicion is that this should choose 8.6 on recent Ubuntu, but if you know otherwise do speak up.