Deprecate names for composite types in favor of fieldnames
#10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebolewski
force-pushed
the
jcb/fieldnames
branch
from
cbc538d
to
c1ba6a5
Compare
|
I thought the idea was to use fieldnames just to mean the field names of a composite type, and |
|
Yeah, I was not really sure about that. I'll change it. |
jakebolewski
changed the title
names in favor of fieldnamesnames for composite types in favor of fieldnames
jakebolewski
force-pushed
the
jcb/fieldnames
branch
from
aa8ee40
to
a64d071
Compare
|
The module changes have been removed. |
|
Looks good, but this should be in NEWS.md |
| @@ -797,7 +797,7 @@ sparse(D::Dense) = sparse(Sparse(D)) | |||
| # Calculate the offset into the stype field of the cholmod_sparse_struct and | |||
| # change the value | |||
| function change_stype!(A::Sparse, i::Integer) | |||
| offset = fieldoffsets(C_Sparse)[names(C_Sparse) .== :stype][1] | |||
| offset = fieldoffsets(C_Sparse)[9] # field offset of C_Sparse.stype | |||
There was a problem hiding this comment.
no one is going to remember to change this...
- deprecate names() - abstract getting number of fields with `nfields`
jakebolewski
force-pushed
the
jcb/fieldnames
branch
from
a64d071
to
078eed6
Compare
| @@ -28,7 +28,7 @@ New language features | |||
|
|
|||
| Language changes | |||
| ---------------- | |||
|
|
|||
There was a problem hiding this comment.
What?
Adding trailing whitespace?
jakebolewski
force-pushed
the
jcb/fieldnames
branch
from
078eed6
to
485b9de
Compare
jakebolewski
added a commit
that referenced
this pull request
Feb 27, 2015
Deprecate `names` for composite types in favor of `fieldnames`
|
For shame, there is no doc update here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10325.