Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is parseint(Int,x) not called parse(Int, x) #10531

Closed
SimonDanisch opened this issue Mar 16, 2015 · 6 comments
Closed

Why is parseint(Int,x) not called parse(Int, x) #10531

SimonDanisch opened this issue Mar 16, 2015 · 6 comments

Comments

@SimonDanisch
Copy link
Contributor

Sounds pretty redundant and inconsistent to me.
I don't know why it would be a problem to overload it with parse.
If it is parse(Expr, x), things will be even more clear and consistent.

Best,
Simon

@StefanKarpinski
Copy link
Sponsor Member

Making this more generic is definitely a good direction. One issue is that parse(::String) doesn't always return an Expr object.

@SimonDanisch
Copy link
Contributor Author

Ah yeah, and that is also relatively annoying. I just got "bitten" by that earlier.
But I guess it's pretty hard not to do it this way...
Return Expr(:block, :sym) isn't a sensitive solution, I guess...
Is symbol even the only exception?

@JeffBezanson
Copy link
Sponsor Member

I believe tanmay has a PR open to do this.

@jakebolewski
Copy link
Member

Some number literals.

@nalimilan
Copy link
Member

See #9487.

@JeffBezanson
Copy link
Sponsor Member

Now #10543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants