Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move blas_ functions into BLAS? #10548

Closed
JeffBezanson opened this issue Mar 17, 2015 · 3 comments · Fixed by #16600
Closed

move blas_ functions into BLAS? #10548

JeffBezanson opened this issue Mar 17, 2015 · 3 comments · Fixed by #16600
Labels
domain:linear algebra Linear algebra status:help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@JeffBezanson
Copy link
Sponsor Member

We have Base.blas_vendor and Base.blas_set_num_threads (which is exported). Could these be moved into the BLAS module instead?

@tkelman
Copy link
Contributor

tkelman commented Mar 18, 2015

This seems like it should be fine to me. A handful of packages do need to check blas_vendor during their bindeps setup, but referring to the function from a different module depending on VERSION should be simple enough to deal with.

@andreasnoack
Copy link
Member

Yes. I think this is fine.

@ViralBShah
Copy link
Member

Yeah - should be ok. When we wrap other BLAS libraries, those modules should provide the same interfaces as well.

@ihnorton ihnorton added the status:help wanted Indicates that a maintainer wants help on an issue or pull request label Mar 24, 2015
@JeffBezanson JeffBezanson added the domain:linear algebra Linear algebra label Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra status:help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants