Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2 tests should not permanently alter system global git config #13377

Closed
tkelman opened this issue Sep 30, 2015 · 4 comments
Closed

libgit2 tests should not permanently alter system global git config #13377

tkelman opened this issue Sep 30, 2015 · 4 comments
Labels
domain:packages Package management and loading test This change adds or pertains to unit tests

Comments

@tkelman
Copy link
Contributor

tkelman commented Sep 30, 2015

Running make test-libgit2 results in the global git config getting overwritten with Test User, Test@User.com. This should be made temporary and local.

edit: apparently it only overrides the global gitconfig if it hasn't been set yet?

@tkelman tkelman added the domain:packages Package management and loading label Sep 30, 2015
@wildart
Copy link
Member

wildart commented Sep 30, 2015

It happens only when user.name or user.email is empty. I recall that without these parameters set, libgit2 calls will segfault.

@tkelman
Copy link
Contributor Author

tkelman commented Sep 30, 2015

We should at least detect that situation and put it back to the way it was when we're done.

@tkelman tkelman added the test This change adds or pertains to unit tests label Sep 30, 2015
@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 30, 2015

or change $HOME to a temporary location?

@wildart
Copy link
Member

wildart commented Oct 5, 2015

Fixed it in #13417

@wildart wildart closed this as completed Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:packages Package management and loading test This change adds or pertains to unit tests
Projects
None yet
Development

No branches or pull requests

3 participants