Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm.dbg.value missing llvm Verifier pass for SROA #13754

Closed
Keno opened this issue Oct 25, 2015 · 13 comments
Closed

llvm.dbg.value missing llvm Verifier pass for SROA #13754

Keno opened this issue Oct 25, 2015 · 13 comments
Labels
codegen Generation of LLVM IR and native code upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@Keno
Copy link
Member

Keno commented Oct 25, 2015

Right now on LLVM 3.7, we crash at the end of boostrap with a whole bunch of error message similar to

piece covers entire variable
  call void @llvm.dbg.value(metadata i64 1, i64 0, metadata !23687, metadata !23692), !dbg !23688
!23687 = !DILocalVariable(tag: DW_TAG_auto_variable, name: "#s286", scope: !2295, file: !2293, line: 10, type: !9)
!23692 = !DIExpression(DW_OP_bit_piece, 0, 64)

This was notes by @yuyichao in 84a0bc0#commitcomment-13941754.
I have filed this upstream as https://llvm.org/bugs/show_bug.cgi?id=25308 with a reduced test case.
@Keno Keno added the upstream The issue is with an upstream dependency, e.g. LLVM label Oct 25, 2015
@Keno
Copy link
Member Author

Keno commented Oct 25, 2015

Ok, looking at the reduced test case more closely. This seems to just be our sloppiness about emitting debug info for unboxed types catching up with us. I think the action items are two things:

  1. Teach the LLVM Verifier to detect this case (to make sure we don't accidentally end up here again as LLVM passes get better)
  2. Fix our emitted debug info

@Keno Keno removed the upstream The issue is with an upstream dependency, e.g. LLVM label Oct 25, 2015
@yuyichao yuyichao added the codegen Generation of LLVM IR and native code label Oct 25, 2015
@Keno Keno mentioned this issue Oct 25, 2015
Merged
@tkelman
Copy link
Contributor

tkelman commented Oct 30, 2015

Crash is fixed. Close, or rename for remaining todo?

@Keno
Copy link
Member Author

Keno commented Oct 30, 2015

Keep open until I get the Verifier fixes upstream

@Keno Keno added the upstream The issue is with an upstream dependency, e.g. LLVM label Oct 30, 2015
@Keno
Copy link
Member Author

Keno commented Nov 3, 2015

Verifier changes are here: http://reviews.llvm.org/D14276

@Keno
Copy link
Member Author

Keno commented Jan 15, 2016

llvm-mirror/llvm@621b821

@Keno Keno closed this as completed Jan 15, 2016
@Keno
Copy link
Member Author

Keno commented Jan 15, 2016

Aannd, I broke Chrome. Reverted pending investigation.

@Keno Keno reopened this Jan 15, 2016
@tkelman
Copy link
Contributor

tkelman commented Jan 15, 2016

Extra points for style. If you're going to break something, may as well aim big.

@Keno
Copy link
Member Author

Keno commented Jan 15, 2016

I'll go for the Linux kernel next.

@StefanKarpinski
Copy link
Sponsor Member

Can you compile the kernel with Clang?

@Keno
Copy link
Member Author

Keno commented Jan 15, 2016

Ish: http://llvm.linuxfoundation.org/index.php/Main_Page

@tkelman
Copy link
Contributor

tkelman commented Mar 11, 2016

Did this get re-applied in a way that didn't break Chrome?

@Keno
Copy link
Member Author

Keno commented Mar 11, 2016

No, still pending. I'll get back to it when I have a chance.

@vtjnash vtjnash changed the title LLVM 3.7 SROA mistranslates our debug info causing crash llvm.dbg.value missing llvm Verifier pass for SROA Mar 26, 2016
@KristofferC
Copy link
Sponsor Member

Still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen Generation of LLVM IR and native code upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@StefanKarpinski @yuyichao @ViralBShah @KristofferC @Keno @tkelman