Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse(p::Pair) on release-0.4 #14259

Merged
merged 1 commit into from Dec 4, 2015

Conversation

zhmz90
Copy link
Contributor

@zhmz90 zhmz90 commented Dec 4, 2015

The same as PR #14246 which is added a "backport pending 0.4" label

@tkelman
Copy link
Contributor

tkelman commented Dec 4, 2015

This works, though if you do a future backport commit I like to do git cherry-pick -x -e $SHA, which will automatically add a cross-reference to the original commit. The -e will open the commit message for editing, where I like to also add a "ref #14246" to indicate the PR the change originally came from. I will write all these backporting recommendations down over the holidays once my own personal issue #8839 is closed.

@yuyichao
Copy link
Contributor

yuyichao commented Dec 4, 2015

once my own personal issue #8839 is closed.

Should we track it here? =)

@zhmz90
Copy link
Contributor Author

zhmz90 commented Dec 4, 2015

Thank you @tkelman , I will try it next time.

tkelman added a commit that referenced this pull request Dec 4, 2015
Fix reverse(p::Pair) on release-0.4
@tkelman tkelman merged commit 2092e10 into JuliaLang:release-0.4 Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants