added extrema(A,dims) #15550
Merged
added extrema(A,dims) #15550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2083,11 +2083,18 @@ appended to an internal buffer of backtraces. | |||
| :@profile | |||
|
|
|||
| """ | |||
| extrema(itr) | |||
| extrema(itr) -> Tuple | |||
There was a problem hiding this comment.
you need to adjust the rst signature to match this change, add the new signature to the rst, run make docs and commit the generated rst
There was a problem hiding this comment.
i'm sorry, but could you be more specific? how do i "add the new signature to the rst"? thanks.
|
@tkelman docs are now fixed |
bjarthur
force-pushed
the
extrema
branch
3 times, most recently
from
97b93d2
to
a44abb4
Compare
|
Looks okay to me but could use a correctness double check from someone familiar with the cartesian macros. |
| (@nref $N B j) = (BJ[1], AI) | ||
| end | ||
| end | ||
| squeeze(B, tuple(find([sB...].==1)...)) |
There was a problem hiding this comment.
I'd get rid of this squeeze for consistency with minimum(A, dims), maximum(A, dims), etc.
|
squeeze removed |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimumandmaximumalready have adimsoption, but notextrema, so i added it. see #15376 and #3893 for discussion.