support 256 colors in print_with_color and env variables #18473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,10 +16,14 @@ const text_colors = AnyDict( | |||
| :bold => "\033[1m", | |||
| ) | |||
|
|
|||
| for i in 0:256 | |||
There was a problem hiding this comment.
lol yeah. Should be 0:255...
There was a problem hiding this comment.
I'm going to start calling you Tony "Eagle Eye" Kelman, a well-earned nickname.
KristofferC
force-pushed
the
kc/print_ALL_the_colors_or_at_least_256
branch
from
c2de47c
to
94e277b
Compare
|
This should be fairly uncontroversial since it doesn't change any old behavior. Anyone opposed for merging? |
tkelman
approved these changes
Sep 17, 2016
| buf = IOBuffer() | ||
|
|
There was a problem hiding this comment.
this newline seems unnecessary
KristofferC
force-pushed
the
kc/print_ALL_the_colors_or_at_least_256
branch
from
8567e7e
to
6dc9853
Compare
|
Added a NEWS entry so maybe someone could look through that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now people can have their orange warning messages: