Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize fix for libgit2 SSL certificates #18963

Closed
staticfloat opened this issue Oct 16, 2016 · 5 comments
Closed

Finalize fix for libgit2 SSL certificates #18963

staticfloat opened this issue Oct 16, 2016 · 5 comments
Assignees
@staticfloat
Labels
kind:upstream The issue is with an upstream dependency, e.g. LLVM libgit2 The libgit2 library or the LibGit2 stdlib module

Comments

@staticfloat
Copy link
Sponsor Member

Putting this here to remind us to fix this, after discussion in libgit2/libgit2#3935 (comment) settles on a reasonable modification to that pull request. This will involve editing the locally-carried patch to libgit2.
@staticfloat staticfloat added this to the 0.6.0 milestone Oct 16, 2016
@staticfloat staticfloat self-assigned this Oct 16, 2016
@kshyatt kshyatt added the libgit2 The libgit2 library or the LibGit2 stdlib module label Oct 17, 2016
@StefanKarpinski
Copy link
Sponsor Member

This is essentially an upstream issue tracker, hopefully to be resolved by 0.6.

@tkelman tkelman added the kind:upstream The issue is with an upstream dependency, e.g. LLVM label Oct 27, 2016
@tkelman
Copy link
Contributor

tkelman commented Dec 15, 2016

Don't think there's anything we can do here where we have control over the timeline, all the patch changes we need should be in for bugs we've found. Bumping to 1.0 so we hopefully don't forget about getting it resolved properly upstream.

@tkelman tkelman modified the milestones: 1.0, 0.6.0 Dec 15, 2016
@StefanKarpinski
Copy link
Sponsor Member

Is this really release blocking? Seems like a bug fix.

@StefanKarpinski StefanKarpinski modified the milestones: 1.x, 1.0 Jul 27, 2017
@StefanKarpinski
Copy link
Sponsor Member

We also potentially want to move LibGit2 out of Base.

@staticfloat
Copy link
Sponsor Member Author

We've dropped that patch now, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staticfloat staticfloat

Labels
kind:upstream The issue is with an upstream dependency, e.g. LLVM libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@staticfloat @StefanKarpinski @kshyatt @tkelman