Broken nested funcs with curly args adds outer func to workspace

[djsegal]

Simplest Example:

function foo()
   function bar(fizz::Buzz)
   end
end

gives you:

ERROR: UndefVarError: Buzz not defined

however, foo is still defined:

> isdefined(:foo)
true

> foo
foo (generic function with 0 methods)

[JeffBezanson]

I'm inclined to say this is won't-fix; in general if part of a top-level expression fails we don't try to undo the effects of other parts of the expression.

[StefanKarpinski]

One approach to fixing this specific issue would be checking that all references to external values are bound. Of course, any other error while evaluating would still have this problem, but it's a bit better. Seems like a pretty low priority though.

[JeffBezanson]

I'm also not clear on why this particular case is a problem. It should be pretty harmless for foo to be defined, since adding or changing its methods later will work fine.

[djsegal]

@Stefan, are you talking about the curlys and ::'s that are sent to funcs as args?

---

@jeff, But won't you get the redefining warning?

[JeffBezanson]

But won't you get the redefining warning?

Not anymore, no. But even if you did, getting a warning is the least of your problems if your code has an undefined var error.