Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elementary operations for Tridiagonal and SymTridiagonal matrices #2611

Merged
merged 4 commits into from
Mar 19, 2013
Merged

Elementary operations for Tridiagonal and SymTridiagonal matrices #2611

merged 4 commits into from
Mar 19, 2013

Conversation

jiahao
Copy link
Member

@jiahao jiahao commented Mar 19, 2013

Fleshed out elementary +,-,x,\ operations on Tridiagonal and SymTridiagonal matrices as well as transpose(), conj() and ctranspose()

Where necessary (esp. in matrix multiply) the output type changes so that the output is still preserved gracefully. In particular where needed:

  • SymTridiagonal is converted to Tridiagonal or dense
  • Tridiagonal is converted to dense

Fixed apparent bug in copy(Symdiagonal)

Also some light cleanup of tridiag.jl

Replaces pull request #2608.

Extends conj(), transpose() and ctranspose() to Tridiagonal matrices

Also adds very elementary tests of these functions
…agonal matrices

Where necessary (esp. in matrix multiply) the output type changes so that the output is still preserved gracefully. In particular where needed:
- SymTridiagonal is converted to Tridiagonal or dense
- Tridiagonal is converted to dense

Fixed apparent bug in copy(Symdiagonal)

Also some light cleanup of tridiag.jl
ViralBShah pushed a commit that referenced this pull request Mar 19, 2013
Elementary operations for Tridiagonal and SymTridiagonal matrices
@ViralBShah ViralBShah merged commit 8b29497 into JuliaLang:master Mar 19, 2013
@ViralBShah
Copy link
Member

Did you do a make testall to check that all tests pass? All the tests fail for me. I have currently disabled the tests.

@jiahao jiahao deleted the tridiag-simpleops branch March 22, 2013 22:44
@jiahao
Copy link
Member Author

jiahao commented Mar 22, 2013

Ah, Tridiagonal doesn't have == defined. I'll put this in for Tridiagonal and SymTridiagonal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants