Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BasicREPL struct to match LineEditREPL #26526

Open
non-Jedi opened this issue Mar 19, 2018 · 0 comments
Open

Change BasicREPL struct to match LineEditREPL #26526

non-Jedi opened this issue Mar 19, 2018 · 0 comments
Labels
REPL Julia's REPL (Read Eval Print Loop)

Comments

@non-Jedi
Copy link
Contributor

non-Jedi commented Mar 19, 2018

I was trying to figure out what functionality from LineEditREPL
ASTInterpreter2 was using that kept it from being able to run on BasicREPL.
The stack trace it raises says:

ERROR: type BasicREPL has no field t

which is true. However BasicREPL does have an attribute terminal which is of
the same type as the attribute t of LineEditREPL. I couldn't figure out why
this might be intentional, so I thought it might be an implementation bug. For
reference, BasicREPL was added
here
.
At that point, LineEditREPL already had attribute, t, and neither
BasicREPL nor LineEditREPL has changed since.

Disclaimer: I know shockingly little about how shells/terminals work, and
getting ASTInterpreter2 to run in BasicREPL could well be a fools errand,
but this seemed worth addressing anyway. If nobody can think of a reason for
LineEditREPL and BasicREPL to have the same type of attribute with different
names, I'll make a PR to fix that up.

@JeffBezanson JeffBezanson added the REPL Julia's REPL (Read Eval Print Loop) label Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

No branches or pull requests

2 participants