Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows triggers assertion in debug mode with ssp #27603

Closed
vchuravy opened this issue Jun 15, 2018 · 1 comment
Closed

Windows triggers assertion in debug mode with ssp #27603

vchuravy opened this issue Jun 15, 2018 · 1 comment
Assignees
@vchuravy @Keno
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries kind:upstream The issue is with an upstream dependency, e.g. LLVM system:windows Affects only Windows
Milestone
0.7

Comments

@vchuravy
Copy link
Sponsor Member

vchuravy commented Jun 15, 2018 •
edited by Keno
Loading

Originally reported by @vtjnash (https://gist.github.com/vchuravy/53b75ef8659630984caa6b17acdc8903), but it took me a while to reproduce as #27182 (comment)

Keno, bisected this to https://reviews.llvm.org/D41293 which was reverted and landed multiple time. The final version seems to be:

but I have been struggling with backporting that. I decided that I want to land #27182 sooner than later since people are tripping up on those, but we should not forget about this.
@vchuravy vchuravy added kind:upstream The issue is with an upstream dependency, e.g. LLVM system:windows Affects only Windows external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jun 15, 2018
@vchuravy vchuravy added this to the 0.7 milestone Jun 15, 2018
@Keno Keno mentioned this issue Jun 15, 2018
Merged
@vchuravy
Copy link
Sponsor Member Author

Fixed by #27182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchuravy vchuravy

@Keno Keno

Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries kind:upstream The issue is with an upstream dependency, e.g. LLVM system:windows Affects only Windows
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@vchuravy @Keno