Fix download agent search relying on throwing of Sys.which()
#28157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
referenced
this pull request
Jul 18, 2018
This fixes issues on systems that don't have `which` available
vtjnash
reviewed
Jul 18, 2018
| try | ||
| downloadcmd = basename(something(Sys.which.(download_agents)...)) | ||
| catch | ||
| error("no download agent available; install curl, wget, or fetch") | ||
| end |
There was a problem hiding this comment.
Would be better (and not longer) to write this as a loop, rather than obscuring all errors with this message
There was a problem hiding this comment.
What else can throw here except something(nothing)?
There was a problem hiding this comment.
I agree it would be nicer to do without try/catch entirely, since that's now possible here.
Merged
KristofferC
pushed a commit
that referenced
this pull request
Sep 4, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this code was transferred over, it relied on
Sys.which()throwing, which was changed in theSys.which()PR, but this code snippet never got updated.