absolutify --project path #28625

fredrikekre · 2018-08-13T09:25:07Z

Fixes:

julia> Base.active_project()
"/home/fredrik/.julia/dev/Pkg/Project.toml"

julia> cd("Pkg")

julia> Base.active_project()
"/home/fredrik/.julia/dev/Pkg/Pkg/Project.toml"

note Pkg/Pkg in the second path.

vtjnash · 2018-08-13T10:17:57Z

base/initdefs.jl

@@ -136,10 +136,10 @@ function init_load_path()
    end
    project = (JLOptions().project != C_NULL ?
        unsafe_string(Base.JLOptions().project) :


This should probably be handled in init.c, for conisistency with all other options that define paths

The abspath call? Like

julia/src/init.c

Lines 587 to 594 in 0846eb5

if (jl_options.outputo)

jl_options.outputo = abspath(jl_options.outputo, 0);

if (jl_options.outputji)

jl_options.outputji = abspath(jl_options.outputji, 0);

if (jl_options.outputbc)

jl_options.outputbc = abspath(jl_options.outputbc, 0);

if (jl_options.machine_file)

jl_options.machine_file = abspath(jl_options.machine_file, 0);

?

We still need the abspath here for relative paths from JULIA_PROJECT though.

StefanKarpinski · 2018-08-13T16:08:19Z

julia> Base.active_project()
"/home/fredrik/.julia/dev/Pkg/Project.toml"

How did you start Julia to get this?

StefanKarpinski · 2018-08-13T16:05:11Z

base/initdefs.jl

    HOME_PROJECT[] =
        project == "" ? nothing :
-        project == "@." ? current_project() : project
+        project == "@." ? current_project() : abspath(project)


If we resolve this at startup time, you can't do --project=. and have it follow you around. I'm not sure if resolving it at startup or having it follow you around is better.

Following around to the exact pwd is something I think you rarely want.

➜ Pkg git:(kc/free_repo) ✗ ~/julia/julia --project=. (Pkg) pkg> shell> cd src/ /Users/kristoffer/.julia/dev/Pkg/src (src) pkg>

What you might want is to have the same behavior as we had before where you try to find the project based on your current path by looking in parent folders, but we wanted to write that as @.. or something?

We tried to move away from pwd being important so I think abspath here is definitely right.

@fredrikekre could just change this to project === nothing ? nothing : abspath(project) to fix Stefans comment?

There's no way to do that from the command-line or environment, but you can accomplish it now by doing Base.HOME_PROJECT[] = "@." to circumvent the startup time expansion and delay it until load time.

StefanKarpinski · 2018-08-13T16:06:28Z

base/initdefs.jl

@@ -136,10 +136,10 @@ function init_load_path()
    end
    project = (JLOptions().project != C_NULL ?
        unsafe_string(Base.JLOptions().project) :
-        get(ENV, "JULIA_PROJECT", nothing))
+        get(ENV, "JULIA_PROJECT", ""))


This has a behavioral side effect: it makes setting JULIA_PROJECT to the empty string behave the same as having it unset, which doesn't seem ideal and is something that I've generally avoided.

fredrikekre · 2018-08-13T21:17:09Z

How did you start Julia to get this?

julia-master --project=Pkg

If we resolve this at startup time, you can't do --project=. and have it follow you around. I'm not sure if resolving it at startup or having it follow you around is better.

I agree with Kristoffer here. The reason I found this is that I made a doc-build project with needed deps, but Documenter cds to the build directory, so when I tried to load packages from doctests I got an error, since the env had changed.

There's no way to do that from the command-line or environment, but you can accomplish it now by doing Base.HOME_PROJECT[] = "@."

We can skip the abspath call in init_load_path and only keep the one for the command line flag in init.c. That way you can set JULIA_PROJECT=@. to get that behaviour.

fredrikekre · 2018-08-14T10:54:11Z

I changed this to only absolutify --project paths. That is now consistent with how we treat other command line arguments that accepts paths. I left JULIA_PROJECT alone; we don't call abspath for other environment variables, so that is consistent. Also, I think it makes sense to abspath --project but not JULIA_PROJECT since --project paths are much more local to the process that you start, environment variables should "work" wherever you start julia, and hence it is expected that those are set as absolute paths from the user. Thoughts?

StefanKarpinski · 2018-08-14T18:00:45Z

We can skip the abspath call in init_load_path and only keep the one for the command line flag in init.c. That way you can set JULIA_PROJECT=@. to get that behaviour.

That's not what everyone thought was the better default when I was working on that.

fredrikekre · 2018-08-14T18:21:05Z

Sorry, I was answering this:

If we resolve this at startup time, you can't do --project=. and have it follow you around.

Which you can still accomplish with JULIA_PROJECT=. if you want.

StefanKarpinski · 2018-08-14T18:26:50Z

Which you can still accomplish with JULIA_PROJECT=. if you want.

No, they'd both be resolved at startup time. You'd have to do Base.HOME_PROJECT[] = ".".

fredrikekre · 2018-08-14T18:33:40Z

No, they'd both be resolved at startup time.

Not in the state the PR is now.

StefanKarpinski · 2018-08-14T18:36:01Z

I don't think that changing the way the command-line option and the environment variable behave is a great idea. That seems like it will be a huge source of confusion.

KristofferC · 2018-08-19T22:31:45Z

Bump, would be nice to have this bug fixed in 1.0.1. What can we do to make progress here?

fredrikekre · 2018-08-20T06:15:51Z

What can we do to make progress here?

Merge?

So the problem I have with the current behaviour is that the environment I explicitly choose to start julia with is changed under my feet, by code that does not do any Pkg operations (only cd). I understand that I maybe can't control this if the code explicitly changes environment, but I feel like environment unaware code should not change which code I will load.

I guess the question is if we should do the same for JULIA_PROJECT (which was in here from the beginning), I think that might be good to add back maybe.

KristofferC · 2018-08-20T09:26:48Z

Yes, unless we are explicit we don't want to accidentally activate random environments by changing pwd (which is a security concern).

@StefanKarpinski, do you have any issue with the current implementation? Barring comments, I will merge this in a couple of days.

* Use projects for doc build and code coverage submission. * workaround JuliaLang/julia/pull/28625

fredrikekre · 2018-08-23T11:24:15Z

I added back the absolutification of JULIA_PROJECT, so now JULIA_PROJECT and --project behaves the same. In the rare case that one wants to make the project follow pwd(), then it is possible to Base.HOME_PROJECT[] = ".".

StefanKarpinski · 2018-08-24T18:55:15Z

That makes me much happier with this :)

vtjnash · 2018-08-24T20:38:53Z

src/init.c

@@ -593,6 +593,8 @@ static void jl_resolve_sysimg_location(JL_IMAGE_SEARCH rel)
        jl_options.outputbc = abspath(jl_options.outputbc, 0);
    if (jl_options.machine_file)
        jl_options.machine_file = abspath(jl_options.machine_file, 0);
+    if (jl_options.project && strncmp(jl_options.project, "@.", strlen(jl_options.project)) != 0)


can use strcmp – this would just be a more verbose and slower way of implementing that

…28625) (cherry picked from commit eb8a933)

fredrikekre added kind:bugfix This change fixes an existing bug backport pending 1.0 labels Aug 13, 2018

fredrikekre requested review from StefanKarpinski and KristofferC August 13, 2018 09:25

vtjnash reviewed Aug 13, 2018

View reviewed changes

fredrikekre force-pushed the fe/absolute-project branch from 0131a55 to dd3e092 Compare August 13, 2018 11:09

StefanKarpinski reviewed Aug 13, 2018

View reviewed changes

mortenpi mentioned this pull request Aug 13, 2018

Tildes in the --project argument #28638

Closed

fredrikekre force-pushed the fe/absolute-project branch from dd3e092 to e7b3167 Compare August 14, 2018 10:06

fredrikekre changed the title ~~absolutify --project and JULIA_PROJECT paths~~ absolutify --project path Aug 14, 2018

fredrikekre force-pushed the fe/absolute-project branch from e7b3167 to c945090 Compare August 14, 2018 10:50

fredrikekre force-pushed the fe/absolute-project branch 2 times, most recently from b54b46a to fc5324d Compare August 14, 2018 11:15

KristofferC mentioned this pull request Aug 19, 2018

Backports to 1.0.1 #28764

Merged

fredrikekre added a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Aug 22, 2018

workaround JuliaLang/julia/pull/28625

29b6a89

fredrikekre added a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Aug 22, 2018

workaround JuliaLang/julia/pull/28625

8d0d78f

fredrikekre added a commit to Ferrite-FEM/Ferrite.jl that referenced this pull request Aug 22, 2018

Use projects for documentation and code coverage (#227)

de3d919

* Use projects for doc build and code coverage submission. * workaround JuliaLang/julia/pull/28625

Absolutify project path specified with --project and JULIA_PROJECT.

c96025c

fredrikekre force-pushed the fe/absolute-project branch from fc5324d to c96025c Compare August 23, 2018 08:29

fredrikekre merged commit eb8a933 into JuliaLang:master Aug 24, 2018

fredrikekre deleted the fe/absolute-project branch August 24, 2018 19:12

vtjnash reviewed Aug 24, 2018

View reviewed changes

KristofferC pushed a commit that referenced this pull request Aug 24, 2018

Absolutify project path specified with --project and JULIA_PROJECT. (#…

7d84e46

…28625) (cherry picked from commit eb8a933)

KristofferC pushed a commit that referenced this pull request Sep 8, 2018

Absolutify project path specified with --project and JULIA_PROJECT. (#…

0c51ed2

…28625) (cherry picked from commit eb8a933)

KristofferC pushed a commit that referenced this pull request Sep 8, 2018

Absolutify project path specified with --project and JULIA_PROJECT. (#…

75b052f

…28625) (cherry picked from commit eb8a933)

odow mentioned this pull request Sep 23, 2018

Add build stage for documentation jump-dev/JuMP.jl#1485

Merged

KristofferC removed the backport pending 1.0 label Sep 27, 2018

fredrikekre mentioned this pull request Nov 8, 2018

Project for docs. KristofferC/PGFPlotsX.jl#131

Merged

vtjnash mentioned this pull request Dec 13, 2018

coverage: support output in LCOV tracefile format #30381

Merged

KristofferC pushed a commit that referenced this pull request Feb 11, 2019

Absolutify project path specified with --project and JULIA_PROJECT. (#…

58e2a6a

…28625) (cherry picked from commit eb8a933)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

absolutify --project path #28625

absolutify --project path #28625

fredrikekre commented Aug 13, 2018

vtjnash Aug 13, 2018

fredrikekre Aug 13, 2018

fredrikekre Aug 13, 2018

StefanKarpinski commented Aug 13, 2018

StefanKarpinski Aug 13, 2018

KristofferC Aug 13, 2018 •

edited

Loading

KristofferC Aug 13, 2018 •

edited

Loading

StefanKarpinski Aug 13, 2018

StefanKarpinski Aug 13, 2018

fredrikekre commented Aug 13, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

KristofferC commented Aug 19, 2018

fredrikekre commented Aug 20, 2018

KristofferC commented Aug 20, 2018

fredrikekre commented Aug 23, 2018 •

edited

Loading

StefanKarpinski commented Aug 24, 2018

vtjnash Aug 24, 2018

	if (jl_options.outputo)
	jl_options.outputo = abspath(jl_options.outputo, 0);
	if (jl_options.outputji)
	jl_options.outputji = abspath(jl_options.outputji, 0);
	if (jl_options.outputbc)
	jl_options.outputbc = abspath(jl_options.outputbc, 0);
	if (jl_options.machine_file)
	jl_options.machine_file = abspath(jl_options.machine_file, 0);

absolutify --project path #28625

absolutify --project path #28625

Conversation

fredrikekre commented Aug 13, 2018

vtjnash Aug 13, 2018

Choose a reason for hiding this comment

fredrikekre Aug 13, 2018

Choose a reason for hiding this comment

fredrikekre Aug 13, 2018

Choose a reason for hiding this comment

StefanKarpinski commented Aug 13, 2018

StefanKarpinski Aug 13, 2018

Choose a reason for hiding this comment

KristofferC Aug 13, 2018 • edited Loading

Choose a reason for hiding this comment

KristofferC Aug 13, 2018 • edited Loading

Choose a reason for hiding this comment

StefanKarpinski Aug 13, 2018

Choose a reason for hiding this comment

StefanKarpinski Aug 13, 2018

Choose a reason for hiding this comment

fredrikekre commented Aug 13, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

fredrikekre commented Aug 14, 2018

StefanKarpinski commented Aug 14, 2018

KristofferC commented Aug 19, 2018

fredrikekre commented Aug 20, 2018

KristofferC commented Aug 20, 2018

fredrikekre commented Aug 23, 2018 • edited Loading

StefanKarpinski commented Aug 24, 2018

vtjnash Aug 24, 2018

Choose a reason for hiding this comment

KristofferC Aug 13, 2018 •

edited

Loading

KristofferC Aug 13, 2018 •

edited

Loading

fredrikekre commented Aug 23, 2018 •

edited

Loading