smarter order of checks in jl_types_equal #28677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works around the test issue in RDatasets
JeffBezanson
added
the
domain:types and dispatch
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
this works around the test issue in RDatasets (cherry picked from commit af3c452)
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
this works around the test issue in RDatasets (cherry picked from commit af3c452)
Merged
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
this works around the test issue in RDatasets (cherry picked from commit af3c452)
|
When will this be reflected in the released version? Or perhaps more relevant, how can I test this fix? |
|
@LeoK987, you can use nightly binaries or build Julia's master branch. A release 1.0.1 is in the works, and that will include this change. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
this works around the test issue in RDatasets (cherry picked from commit af3c452)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
this works around the test issue in RDatasets (cherry picked from commit af3c452)
KristofferC
added
kind:bugfix
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
this works around the test issue in RDatasets (cherry picked from commit af3c452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the test issue in RDatasets (JuliaStats/RDatasets.jl#54). We could still use some more fundamental subtyping improvements in such cases, but luckily this simple change fixes it for now.