make cmp with BigInt return in [-1, 0, 1] #28780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to adhere to the documentation.
rfourquet
added
kind:bugfix
Merged
test/bigint.jl
Outdated
| bigrand() = rand(-big(2)^rand(1:rand(1:1000)):big(2)^rand(1:rand(1:1000))) | ||
| for T in (Base.BitInteger_types..., BigInt, Float64, Float32, Float16, BigFloat) | ||
| @test cmp(big(2)^130, one(T)) == 1 | ||
| @test cmp(-big(2)^130, one(T)) == -1 |
There was a problem hiding this comment.
How about testing these with === to ensure that the type matches as well? And throw in some tests where the result is 0 as well...
There was a problem hiding this comment.
Ok, done. I removed the testing with BigFloat as this is handled in the MPFR module, and can return Int32. I can make a PR for MPFR if you think it's useful.
KristofferC
pushed a commit
that referenced
this pull request
Aug 23, 2018
* make cmp with BigInt return in [-1, 0, 1] (cherry picked from commit 472c178)
staticfloat
pushed a commit
that referenced
this pull request
Aug 24, 2018
* make cmp with BigInt return in [-1, 0, 1]
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* make cmp with BigInt return in [-1, 0, 1] (cherry picked from commit 472c178)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* make cmp with BigInt return in [-1, 0, 1] (cherry picked from commit 472c178)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* make cmp with BigInt return in [-1, 0, 1] (cherry picked from commit 472c178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to adhere to the documentation.
The added
signcall doesn't seem to add overhead to the comparison functions usingcmp. Adding thissigncall forcmp(::BigInt, ::UInt)seems unnecessary according to the current GMP implementation ofmpz_cmp_ui, but it's more maintenable to rely only on the documentation (which doesn't make garranties). A similar treatment could be made for MPFR, but my few tries didn't find a case where the values is not in[-1, 0, 1].