@schedule is deprecated, the code is no longer valid in 1.0 #28800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
approved these changes
Aug 21, 2018
Merged
KristofferC
reviewed
Aug 22, 2018
|
|
||
| julia> for i in 1:4 # start 4 tasks to process requests in parallel | ||
| @schedule do_work() | ||
| @async do_work() |
There was a problem hiding this comment.
round(exec_time,2) a few lines below doesn't work on 1.0 should be round(exec_time; digits=2)
There was a problem hiding this comment.
Also, the n = n - 1 needs a global in front of it.
There was a problem hiding this comment.
I have pushed a new commit with those changes. Thanks for the comments, nice catch!
KristofferC
pushed a commit
that referenced
this pull request
Aug 23, 2018
staticfloat
pushed a commit
that referenced
this pull request
Aug 24, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am following the documentation to learn Julia, and I found a macro,
@schedulethat is deprecated in Julia 1.0, according to #27164This pull request simply replaces
@scheduleby@asyncin the Parallel Computing section of the manual.