Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix usage of NTuple{T} #29104

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

stev47
Copy link
Contributor

@stev47 stev47 commented Sep 9, 2018

No description provided.

| **Non-traditional indices** | **Default definition** | **Brief description** |
| `axes(A)` | `map(OneTo, size(A))` | Return the `AbstractUnitRange` of valid indices |
| `Base.similar(A, ::Type{S}, inds::NTuple{Ind})` | `similar(A, S, Base.to_shape(inds))` | Return a mutable array with the specified indices `inds` (see below) |
| `Base.similar(A, ::Type{S}, inds::NTuple{<:Any,Ind})` | `similar(A, S, Base.to_shape(inds))` | Return a mutable array with the specified indices `inds` (see below) |
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be inds (no type) like the entry below it. It's not clear what Ind is, plus NTuple{<:Any is confusing since the first parameter is an integer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

@KristofferC KristofferC added domain:docs This change adds or pertains to documentation backport pending 1.0 labels Sep 12, 2018
@KristofferC KristofferC merged commit 5e4ca86 into JuliaLang:master Sep 12, 2018
KristofferC pushed a commit that referenced this pull request Sep 17, 2018
@KristofferC KristofferC mentioned this pull request Sep 17, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants