Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #22592, specificity of union compared to a subtype of it #29139

Merged
merged 1 commit into from
Sep 13, 2018
Merged

fix #22592, specificity of union compared to a subtype of it #29139

merged 1 commit into from
Sep 13, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

We considered Union{A,B} more specific than B if A was more specific than B (but not a subtype of it). Clearly, it should not be.

@JeffBezanson JeffBezanson added domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug backport pending 1.0 labels Sep 11, 2018
@JeffBezanson
Copy link
Sponsor Member Author

Correction: actually fixes #29136

@JeffBezanson
fix #22592, specificity of union compared to a subtype of it
0908bc4 
We considered Union{A,B} more specific than B if A was more specific
than B (but not a subtype of it). Clearly, it should not be.
@KristofferC KristofferC mentioned this pull request Sep 12, 2018
Merged
@JeffBezanson JeffBezanson merged commit 3143d89 into master Sep 13, 2018
@JeffBezanson JeffBezanson deleted the jb/fix22592 branch September 13, 2018 15:23
@JeffBezanson JeffBezanson mentioned this pull request Sep 13, 2018
Closed
KristofferC pushed a commit that referenced this pull request Sep 17, 2018
@JeffBezanson @KristofferC
fix #22592, specificity of union compared to a subtype of it (#29139)
5ac0cdc 
We considered Union{A,B} more specific than B if A was more specific
than B (but not a subtype of it). Clearly, it should not be.

(cherry picked from commit 3143d89)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@JeffBezanson @KristofferC
fix #22592, specificity of union compared to a subtype of it (#29139)
1fb5c00 
We considered Union{A,B} more specific than B if A was more specific
than B (but not a subtype of it). Clearly, it should not be.

(cherry picked from commit 3143d89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffBezanson @KristofferC