Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorporate testhelpers/Furlong.jl into Test package? #30692

Open
stevengj opened this issue Jan 11, 2019 · 3 comments · May be fixed by #39852
Open

incorporate testhelpers/Furlong.jl into Test package? #30692

stevengj opened this issue Jan 11, 2019 · 3 comments · May be fixed by #39852
Labels
stdlib Julia's standard library testsystem The unit testing framework and Test stdlib

Comments

@stevengj
Copy link
Member

It might be nice to make testhelpers/Furlong.jl available in the Test standard library package, so that external packages could do using Test.Furlongs to perform dimensionful testing without adding a dependency on Unitful.jl.
@stevengj stevengj added the testsystem The unit testing framework and Test stdlib label Jan 11, 2019
@stevengj
Copy link
Member Author

Similarly for some of the other testhelpers, for that matter.

@KristofferC
Copy link
Sponsor Member

To me, adding a test-dependency for those who need it seems like a better choice than to bundle it inside Test to everyone.

Why is adding a test dependency on Unitful a problem?

@JeffBezanson
Copy link
Sponsor Member

👍 These seem to fit with GenericString etc.

@ararslan ararslan added the stdlib Julia's standard library label Jan 12, 2019
This was referenced Feb 27, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Julia's standard library testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Test.GenericDimensionful number type JuliaLang/julia
4 participants
@JeffBezanson @KristofferC @stevengj @ararslan