Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Unicode 12.1.0 #32002

Merged
merged 1 commit into from May 15, 2019
Merged

support for Unicode 12.1.0 #32002

merged 1 commit into from May 15, 2019

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented May 11, 2019

Via utf8proc 2.4.

This adds exactly one character: U+32FF SQUARE ERA NAME REIWA.

@stevengj stevengj added the unicode Related to unicode characters and encodings label May 11, 2019
@stevengj
Copy link
Member Author

Travis OSX failure is unrelated failed running test FileWatching.

@stevengj
Copy link
Member Author

I'll merge in a day or so if there are no objections.

@stevengj stevengj merged commit 5c5f5c2 into master May 15, 2019
@stevengj stevengj deleted the sgj/utf8proc2.4 branch May 15, 2019 12:44
@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented May 16, 2019

Should we backport this to Julia 1.1.1 (too late?) and/or 1.2? As a possible PR stunt to get the Japanese [emperor] exited for Julia?

@PallHaraldsson PallHaraldsson mentioned this pull request May 16, 2019
58 tasks
@StefanKarpinski
Copy link
Sponsor Member

No, this is a feature.

@PallHaraldsson
Copy link
Contributor

Ok, understand for 1.1.1. But not to late for 1.2 as its not released and this a trivial change.

@StefanKarpinski
Copy link
Sponsor Member

Every change has risk. What's the upside? One extra character? It's up to @KristofferC.

@KristofferC
Copy link
Sponsor Member

KristofferC commented May 17, 2019

I think SQUARE ERA NAME REIWA has gotten too much time dedicated to it already ;)

@JeffBezanson
Copy link
Sponsor Member

We have a process. We don't just keep adding anything we feel like to a release up until the moment it is final. That wouldn't work. We declare a feature freeze, and after that point we only add important bug fixes and fixes needed to maintain compatibility. Otherwise a release would never converge to something stable, and we'd have to spend time debating each extra change somebody wants to add, like we're doing now.

@antimon2
Copy link

I sent PR to utf8proc to make Julia support 'U+32FF'.
But I don't need the new character so far as my Julia programming, I'm only interested in technical feature.
I don't need that feature in the next release of Julia immediately. If necessary, I use development build of Julia at my own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants