Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode stdlibs in precompile tests? #37464

Open
StefanKarpinski opened this issue Sep 8, 2020 · 0 comments
Open

don't hardcode stdlibs in precompile tests? #37464

StefanKarpinski opened this issue Sep 8, 2020 · 0 comments

Comments

@StefanKarpinski
Copy link
Sponsor Member

The precompile tests have a list of stdlibs hardcoded in them here:

julia/test/precompile.jl

Lines 291 to 295 in 1378bb6

[:Base64, :CRC32c, :Dates, :DelimitedFiles, :Distributed, :FileWatching, :Markdown,
:Future, :Libdl, :LinearAlgebra, :Logging, :Mmap, :Printf,
:Profile, :Random, :Serialization, :SharedArrays, :SparseArrays, :SuiteSparse, :Test,
:Unicode, :REPL, :InteractiveUtils, :Pkg, :LibGit2, :SHA, :UUIDs, :Sockets,
:Statistics, :TOML]),

I don't really understand why this is hardcoded here—would it be possible to not hardcode this? Otherwise this is a pretty obscure place that needs to be updated if you add or remove stdlibs.

@StefanKarpinski StefanKarpinski changed the title don'tn hardcode stdlibs in precompile tests? don't hardcode stdlibs in precompile tests? Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant