Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dates + works on array of Dates and a single Date #37814

Open
mzgubic opened this issue Sep 30, 2020 · 4 comments · May be fixed by #49832
Open

Dates + works on array of Dates and a single Date #37814

mzgubic opened this issue Sep 30, 2020 · 4 comments · May be fixed by #49832
Labels
dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation

Comments

@mzgubic
Copy link

mzgubic commented Sep 30, 2020

collect(1:23) .+ 1 ✅
collect(1:23) + 1 🙅
Dates.Hour.(0:23) .+ DateTime("20200902", "yyyymmdd") ✅
Dates.Hour.(0:23) + DateTime("20200902", "yyyymmdd") ✅

Is there a reason why these deprecations are commented out? cc @nickrobinson251
@fredrikekre
Copy link
Member

Is there a reason why these deprecations are commented out?

Probably because deprecations were on by default when they were added. We should probably consider turning these on now that deprecations are off by default.

@KristofferC
Copy link
Sponsor Member

Ref #28672, #29509. I think it was an accident they wasn't deprecated in 1.0.

@mzgubic mzgubic closed this as completed Sep 30, 2020
@mzgubic mzgubic reopened this Sep 30, 2020
@JeffBezanson JeffBezanson added deprecation This change introduces or involves a deprecation dates Dates, times, and the Dates stdlib module labels Sep 30, 2020
@JeffBezanson
Copy link
Sponsor Member

Ok, action item is to just uncomment the depwarns.

@omus
Copy link
Member

omus commented Oct 2, 2020 •
edited

Related: #37759 (comment). There is no deprecation currently for +(r::AbstractRange{<:TimeType}, x::Period)

@fredrikekre fredrikekre mentioned this issue Jul 19, 2022
Closed
This was referenced May 16, 2023
Closed
Open
@barucden barucden mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable deprecations for non-broadcasted Dates arithmetic. inkydragon/julia
5 participants
@JeffBezanson @KristofferC @omus @fredrikekre @mzgubic