Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve matrix multiplication and solvers #43799

Closed
bardo84 opened this issue Jan 13, 2022 · 6 comments
Closed

Improve matrix multiplication and solvers #43799

bardo84 opened this issue Jan 13, 2022 · 6 comments
Labels
domain:linear algebra Linear algebra performance Must go faster

Comments

@antoine-levitt
Copy link
Contributor

Would be good to be clear what exactly is missing. Julia can definitely do diagonal/triangular matrix multiplies, it just wants you to use the appropriate types (ie Diagonal instead of plain matrix). It doesn't try to read off properties from the numerical values of the matrix (eg it won't do anything fancy with diagm), which I think is completely reasonable.

@oscardssmith
Copy link
Member

I believe Julia is currently missing optimized Symmetric*Symmetric.

@bardo84
Copy link
Author

bardo84 commented Jan 13, 2022

I have contacted the authors of the paper for input.

@mcabbott
Copy link
Contributor

mcabbott commented Jan 13, 2022

Table 7: Experiment #6 in the paper is also wrong, for Julia 1.7.

Edit: at last I found it, they specify Julia 1.5.2, thus too old for this.

Their article is "[v2] Sun, 5 Sep 2021" without comment on what changed, perhaps they did not re-run experiments.

@ViralBShah ViralBShah added domain:linear algebra Linear algebra performance Must go faster labels Jan 14, 2022
@ViralBShah
Copy link
Member

May I suggest that we use discourse to zero in on the problems and then open specific issues for each case that are actionable? If folks agree, we can close this issue.

@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 14, 2022

Alternatively, if you like, we can convert this issue to a GitHub Discussion - just click on the "convert to discussion link", which will close the issue and convert it to a discussion.

@JuliaLang JuliaLang locked and limited conversation to collaborators Jan 14, 2022
@ViralBShah ViralBShah converted this issue into discussion #43808 Jan 14, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
domain:linear algebra Linear algebra performance Must go faster
Projects
None yet
Development

No branches or pull requests

6 participants