predicate function negation with ComposedFunction #44752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Mar 26, 2022
stevengj
reviewed
Mar 26, 2022
stevengj
reviewed
Mar 26, 2022
markmbaum
commented
Mar 26, 2022
stevengj
reviewed
Mar 26, 2022
stevengj
reviewed
Mar 26, 2022
stevengj
reviewed
Mar 26, 2022
StefanKarpinski
approved these changes
Mar 28, 2022
stevengj
reviewed
Mar 28, 2022
stevengj
reviewed
Mar 28, 2022
stevengj
previously approved these changes
Mar 29, 2022
|
Should have an item in |
stevengj
reviewed
Mar 29, 2022
stevengj
added
needs docs
stevengj
approved these changes
Mar 31, 2022
stevengj
added
the
status:merge me
giordano
reviewed
Apr 4, 2022
…n, update show for ComposedFunction
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
|
|
DilumAluthge
removed
the
status:merge me
|
Nice work and thanks, @markmbaum! Great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44748 , this small PR does the following
!(f::Function) = (!) ∘ fshowmethod forComposedFunctionto print operators in parentheses!(f::ComposedFunction{typeof(!)})that allows!!f === f!!f === fand a few tests for showing composed functionsthanks for the tutelage @stevengj !