allow nested combinations of (named)tuples, symbols, and bits as type parameters #46300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Aug 10, 2022
JeffBezanson
force-pushed
the
jb/moretypeparams
branch
from
48443e5
to
b740656
Compare
JeffBezanson
force-pushed
the
jb/moretypeparams
branch
from
b740656
to
e4a204d
Compare
JeffBezanson
force-pushed
the
jb/moretypeparams
branch
from
e4a204d
to
2e690fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently values can be used as type parameters if they are isbits, or tuples of bits and symbols. That is a bit arbitrary, and it seems to me we might as well allow (at least) trees of tuples and named tuples with bits and symbol leaves. Essentially, symbols count as "isbits" for use as type parameters, so to generalize we could allow anything of that form.