Dict setindex! run time dispatch

[nsajko]

julia> using JET

julia> @report_opt setindex!(Dict{Nothing,Nothing}(), nothing, nothing)
═════ 2 possible errors found ═════
┌ setindex!(h::Dict{Nothing, Nothing}, v0::Nothing, key::Nothing) @ Base ./dict.jl:375
│┌ ht_keyindex2_shorthash!(h::Dict{Nothing, Nothing}, key::Nothing) @ Base ./dict.jl:333
││┌ rehash!(h::Dict{Nothing, Nothing}, newsz::Int64) @ Base ./dict.jl:208
│││┌ setproperty!(x::Dict{Nothing, Nothing}, f::Symbol, v::UInt64) @ Base ./Base.jl:40
││││ runtime dispatch detected: convert(%1::Type, v::UInt64)::Any
│││└────────────────────
││┌ rehash!(h::Dict{Nothing, Nothing}, newsz::Int64) @ Base ./dict.jl:213
│││┌ setproperty!(x::Dict{Nothing, Nothing}, f::Symbol, v::Int64) @ Base ./Base.jl:40
││││ runtime dispatch detected: convert(%1::Type, v::Int64)::Any
│││└────────────────────


julia> versioninfo()
Julia Version 1.11.0-DEV.239
Commit c40ecd3f03a (2023-08-08 03:06 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × AMD Ryzen 3 5300U with Radeon Graphics
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver2)
  Threads: 1 on 8 virtual cores

The lines 208 and 213 are basically simple BitInteger assignments, so it's weird that they cause run time dispatch.

[nsajko]

Note that the types in the assignment and increment don't match, Int vs UInt, however this still seems like it should be OK due to constant propagation 🤷

[Seelengrab]

FWIW, I cannot reproduce this on a slightly earlier version of master, so that's a recent regression.

julia> @report_opt setindex!(Dict{Nothing,Nothing}(), nothing, nothing)
No errors detected


julia> versioninfo()
Julia Version 1.11.0-DEV.122
Commit 0f56da89883 (2023-07-19 09:09 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: 24 × AMD Ryzen 9 7900X 12-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
  Threads: 34 on 24 virtual cores
Environment:
  JULIA_PKG_USE_CLI_GIT = true

[nsajko]

Doesn't repro on ab94fad, but does on 117ef2e. So #50618 caused it, @aviatesk.

[Seelengrab]

Thanks for the bisection! I also can't repro on 1.9.1, so it's truly a regression compared to an earlier release.

[aviatesk]

This seems to be a problem on JET-side. I will update JET and release a new version quickly.