Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new vcat makes other packages vcat ambiguous #52263

Closed
prbzrg opened this issue Nov 21, 2023 · 3 comments
Closed

The new vcat makes other packages vcat ambiguous #52263

prbzrg opened this issue Nov 21, 2023 · 3 comments

Comments

@prbzrg
Copy link
Contributor

prbzrg commented Nov 21, 2023

the vcat in v1.10 is breaking some packages.

JuliaDiff/ReverseDiff.jl#242

jonniedie/ComponentArrays.jl#222

@prbzrg
Copy link
Contributor Author

prbzrg commented Nov 21, 2023

I found the issue:
JuliaSparse/SparseArrays.jl#431
but let's keep this issue open until that gets fix.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Nov 22, 2023

Currently the only permitted (non-type-pirating) methods are to overload the first argument with a custom type or to overload for non-Array types. Current Base claims ownership of that set of method signatures, and SparseArrays even already pirates it so that nobody else can do so. There is an old issue here about making it permitted to add other overloads, but no one has tried to tackle that.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Dec 4, 2023

This should be re-opened on the SparseArrays repo, since the offending pirating method is added there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants