Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in correctness of handling typeinf avoidance #53431

Open
vtjnash opened this issue Feb 22, 2024 · 0 comments
Open

regression in correctness of handling typeinf avoidance #53431

vtjnash opened this issue Feb 22, 2024 · 0 comments
Labels
compiler:codegen Generation of LLVM IR and native code kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Feb 22, 2024

These values in the CodeInstance constructor at the linked comment line appear to be mostly set incorrectly now, which can lead to compile corruption (e.g. #51872), as well as now failing to handle the case when retrieve_code_info may fail and return nothing instead of CodeInfo. The old logic had a helper function jl_get_codeinst_for_src which used to handle this case, so that function could either be un-deleted, or that operation could be added as an alternative way to call the CodeInstance constructor, since it needs identical handling to how result would be treated later.

CodeInstance(interp, src, can_discard_trees=)

Originally posted by @vtjnash in #53219 (comment)

Posting as an issue since the PR is already merged so it doesn't get lost

@vtjnash vtjnash added kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version compiler:codegen Generation of LLVM IR and native code labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

1 participant