regression in thread-safety correctness of detecting compilation finished #53432
Labels
compiler:inference
Type inference
domain:multithreading
Base.Threads and related functionality
kind:regression
Regression in behavior compared to a previous version
Comments
vtjnash
changed the title
vtjnash
added
kind:regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ci_has_abi uses monotonic loads, so #53219 introduced a data-race here. I think it needs an
:acquireon one or move of these to fix that, so that it must observe this being set. And also needs to switch the order of the checks, so that it correctly pairs with the release store.Originally posted by @vtjnash in #53219 (comment)
Posting as an issue since the PR is already merged, so this doesn't get lost
The text was updated successfully, but these errors were encountered: