Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate copies when returning from LAPACK wrappers #9116

Open
andreasnoack opened this issue Nov 23, 2014 · 2 comments
Open

Eliminate copies when returning from LAPACK wrappers #9116

andreasnoack opened this issue Nov 23, 2014 · 2 comments
Assignees
Labels
linear algebra Linear algebra

Comments

@andreasnoack
Copy link
Member

Some of the wrapped LAPACK subroutines for eigenproblems support calculation of a subset of the spectrum and return an intereger of the number of eigenvalues calculated. Right now, the wrappers use this integer to return part of the array used by LAPACK. This creates a copy and we might want to avoid that in the LAPACK wrapper and wait until it is strictly necessary, e.g. in exported methods.

@andreasnoack andreasnoack self-assigned this Nov 23, 2014
@andreasnoack andreasnoack added this to the 0.4 milestone Nov 23, 2014
@andreasnoack andreasnoack added the linear algebra Linear algebra label Nov 23, 2014
@andreasnoack andreasnoack modified the milestones: 0.6.0, 0.4.x May 5, 2016
@andreasnoack andreasnoack removed this from the 0.6.0 milestone Dec 22, 2016
@ViralBShah
Copy link
Member

I think we are largely ok on this now. Close?

@andreasnoack
Copy link
Member Author

andreasnoack commented Jul 24, 2019

Still an issue in

w[1:m[]], Z[:,1:(jobz == 'V' ? m[] : 0)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

No branches or pull requests

2 participants