Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one argument indexing not defined for SymTridiagonal, Bidiagonal, Symmetric and Hermitian #9993

Closed
jakebolewski opened this issue Feb 1, 2015 · 4 comments
Assignees
Labels

Comments

@jakebolewski
Copy link
Member

julia> r = randn(10,10)
julia>  r = (r' * r) ./ 2
julia> t = SymTridiagonal(r)
julia> t[1]
ERROR: indexing not defined for Base.LinAlg.SymTridiagonal{Float64}
 in getindex at abstractarray.jl:434
@jakebolewski jakebolewski self-assigned this Feb 1, 2015
@andreasnoack
Copy link
Member

You are having a party tonight!

I'm wondering if we should define a fallback linear indexing method for AbstractArray. That would also fix #9991.

@jiahao jiahao added the domain:linear algebra Linear algebra label Feb 1, 2015
@jakebolewski jakebolewski changed the title indexing not defined for SymTridiagonal indexing not defined for SymTridiagonal, Bidiagonal, Symmetric and Hermitian Feb 2, 2015
@jakebolewski
Copy link
Member Author

Updated the title to reflect missing indexing functionality. Most methods that takeAbstractArrays as arguments rely on indexing behavior so this is an essential interface for AbstractArray subtypes. Defining a fallback would seem to be the way to go.

@andreasnoack
Copy link
Member

I think two argument indexing is defined for all the types (if it wasn't they couldn't get printed), so maybe the title should say "One argument indexing...". That would also explain why a fall back would work.

@jakebolewski jakebolewski changed the title indexing not defined for SymTridiagonal, Bidiagonal, Symmetric and Hermitian one argument indexing not defined for SymTridiagonal, Bidiagonal, Symmetric and Hermitian Feb 2, 2015
@mbauman
Copy link
Sponsor Member

mbauman commented Jun 12, 2015

Fixed by #10525.

@mbauman mbauman closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants