Test shared library #104
Merged
Test shared library #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add make check target that builds and runs the tests.
|
lgtm |
|
Both builds on Travis succeeded. Did you intend to comment on a different pull request? |
|
The failures are only on mac - perhaps because of the use of clang. |
|
Travis isn't running on osx here, ref 5473e8b |
|
I just realised that. We probably need to import a few more clang fixes from msun from over the last few months, and that may make things pass all the way, or at least more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a make check target that builds and runs the tests using the shared library.
This is a prerequisite for resolving issue #99.