-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKL isn't built on Windows #24
Comments
This comment has been minimized.
This comment has been minimized.
Currently also dealing with this and I think the problem is more complicated. I have tried pinning PackageCompiler to 0.6.4 and 0.6.3 and it still fails. with the pinned version of PackageCompiler, so the problem does not appear to lie their combination. Further, as you can see in this CI run, MKL builds successfully on Julia 1.0, but then throws a different error when actually using it with VML.
On Julia 1.3 the build itself fails as above. |
Further, building MKL already failed on nightly Julia at the end of November, as seen here. The last PackageCompiler update was Dec. 18, and it appears back then it was WinRPM that caused problems. I tried pinning all packages to the versions in the successful Julia 1.0 run, but no luck so far. |
This error was fixed on MKL by a316332. See this successful CI for it: https://ci.appveyor.com/project/andreasnoack/mkl-jl/builds/28053628/job/su5qa4uk4mb5nb3k |
This combination was the latest successful build on Julia 1 Windows: Packages Installed WinRPM ────────── v0.4.2
Installed HTTPClient ────── v0.2.1
Installed Compat ────────── v2.2.0
Installed Libz ──────────── v1.0.0
Installed BinDeps ───────── v0.8.10
Installed BufferedStreams ─ v1.0.0
Installed BinaryProvider ── v0.5.8
Installed PackageCompiler ─ v0.6.4
Installed LibExpat ──────── v0.5.0
Installed URIParser ─────── v0.4.0
Installed LibCURL ───────── v0.5.2
Updating `C:\projects\mkl-jl\Project.toml`
[b99e7846] + BinaryProvider v0.5.8
[9b87118b] + PackageCompiler v0.6.4
[8f399da3] + Libdl
[37e2e46d] + LinearAlgebra
[8dfed614] + Test
Updating `C:\projects\mkl-jl\Manifest.toml`
[9e28174c] + BinDeps v0.8.10
[b99e7846] + BinaryProvider v0.5.8
[e1450e63] + BufferedStreams v1.0.0
[34da2185] + Compat v2.2.0
[0862f596] + HTTPClient v0.2.1
[b27032c2] + LibCURL v0.5.2
[522f3ed2] + LibExpat v0.5.0
[2ec943e9] + Libz v1.0.0
[9b87118b] + PackageCompiler v0.6.4
[30578b45] + URIParser v0.4.0
[c17dfb99] + WinRPM v0.4.2
[2a0f44e3] + Base64
[ade2ca70] + Dates
[8bb1440f] + DelimitedFiles
[8ba89e20] + Distributed
[b77e0a4c] + InteractiveUtils
[76f85450] + LibGit2
[8f399da3] + Libdl
[37e2e46d] + LinearAlgebra
[56ddb016] + Logging
[d6f4376e] + Markdown
[a63ad114] + Mmap
[44cfe95a] + Pkg
[de0858da] + Printf
[3fa0cd96] + REPL
[9a3f8284] + Random
[ea8e919c] + SHA
[9e88b42a] + Serialization
[1a1011a3] + SharedArrays
[6462fe0b] + Sockets
[2f01184e] + SparseArrays
[10745b16] + Statistics
[8dfed614] + Test
[cf7118a7] + UUIDs
[4ec0a83e] + Unicode |
Given The caveat is that jll's require julia 1.3. Or you could just use the binaries that have been wrapped: https://github.com/JuliaBinaryWrappers/MKL_jll.jl |
The problem is that you want Julia's own methods (like matrix multiplication) to call into MKL which with the current code structure requires a sysimage rebuild. |
This is the default MKL.jl repository. |
Yes... Sorry I didn't understand the point you were making. Could you elaborate? |
We can't use MKL.jl on Windows: julia>]add https://github.com/JuliaComputing/MKL.jl results in the error I wrote in the OP |
My reply was regarding MKL_jll and that it doesn't change the fact that the sysimage has to be rebuilt. |
Somewhat off-topic, but who is maintaining MKL_jll/ are packages apart from |
@Crown421 Like most JLL's it's being "maintained" by the @KristofferC My bad, I though it was a MKL build problem rather than a PackageCompiler issue. Should've read the issue in more detail. Sorry for the noise |
So should we switch to PackageCompilerX or something or we can solve this in an easier way? |
I don't think the error |
Is moving to require Julia 1.3 so you rely on the artifacts helpful? I think it is a reasonable requirement if it would simplify the setup issues of binary locations? |
This is not the error that i get. Please see the log I attached in OP. |
CI on my V0.1 branch:
https://travis-ci.com/aminya/MKL.jl/builds/142809478
https://ci.appveyor.com/project/andreasnoack/mkl-jl/builds/29837534
Travis on my patch-3 branch (before REPL-Startup fix) https://travis-ci.com/aminya/MKL.jl/builds/142824221
This shows that the problem is something external like PackageCompiler because I didn't have any issue building patch-3 at that time.
Local build spoiler:
Full Log
The text was updated successfully, but these errors were encountered: