Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specialize similar for Hankel #124

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Don't specialize similar for Hankel #124

merged 1 commit into from
Jan 10, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 3, 2024

Since the output of similar should be mutable, and Hankel doesn't support setindex!, we shouldn't specialize similar(::Hankel) to return a Hankel. This PR removes the specialization.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d47002) 95.25% compared to head (ae26b28) 95.59%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   95.25%   95.59%   +0.33%     
==========================================
  Files           9        9              
  Lines         948      953       +5     
==========================================
+ Hits          903      911       +8     
+ Misses         45       42       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Pull Request Test Coverage Report for Build 7443272770

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.593%

Totals Coverage Status
Change from base Build 7443258038: 0.0%
Covered Lines: 911
Relevant Lines: 953

💛 - Coveralls

@jishnub jishnub merged commit 02f06e5 into master Jan 10, 2024
13 checks passed
@jishnub jishnub deleted the jishnub/similar branch January 10, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant